This repository was archived by the owner on Sep 8, 2022. It is now read-only.
Automate release: settings for dependency versions. #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable building against Scala 2.11.0-SNAPSHOT. Disable `-Xfatal-warnings` to make PR validation less painful. TODO: Re-enable for travis / nightlies. TODO: Bump to Scala 2.11.0-M7, Scalacheck 1.11.0 once they're out.
|
review by @JamesIry puhlease |
|
Why |
|
Because we validate against a tag of each module, so when we deprecate a method (in scala/scala, say), the tagged version that uses that method doesn't build anymore and thus PR validation fails. This happened with partest when Eugene deprecated Context, which was used in the latest release of partest. We don't really want to validate against master everywhere because that's too many moving parts. |
|
over-the-shoulder LGTM by @JamesIry |
adriaanm
added a commit
that referenced
this pull request
Nov 20, 2013
Automate release: settings for dependency versions.
lrytz
pushed a commit
to lrytz/scala-partest
that referenced
this pull request
May 9, 2018
Automate release: settings for dependency versions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable building against Scala 2.11.0-SNAPSHOT.
Disable
-Xfatal-warningsto make PR validation less painful.TODO: Re-enable for travis / nightlies.
TODO: Bump to Scala 2.11.0-M7, Scalacheck 1.11.0 once they're out.